tests/test_squawk_config.py (1)

30-39: Add returncode == 0 assertion — the negative stdout check passes vacuously if squawk produces no output for any reason.

For ALTER TABLE foo ADD COLUMN bar text; with assume_in_transaction = true, squawk should find zero violations and exit 0. Without the returncode guard, a silent failure (empty stdout for any unexpected reason) makes the test a no-op.

✅ Proposed fix

     result = subprocess.run(
         ["squawk", str(sql_file)],
         capture_output=True,
         text=True,
         cwd=tmp_path,
     )
+    assert result.returncode == 0
     assert "prefer-robust-stmts" not in result.stdout

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/test_squawk_config.py` around lines 30 - 39, The test
test_with_assume_in_transaction_suppresses_prefer_robust_stmts should assert the
process exit status so a silent failure doesn't make the negative stdout check
vacuous; after running subprocess.run(...) add an assertion that
result.returncode == 0 (use the returned variable result) to ensure squawk
exited successfully before asserting "prefer-robust-stmts" is not in
result.stdout.

.github/workflows/ci.yml (1)

37-38: grep will abort the step before the friendly error message is reached if the pattern is ever not found.

GitHub Actions runs bash -eo pipefail by default, so a zero-match grep (exit 1) causes an immediate unclean failure at the assignment, bypassing the mismatch message entirely. Guarding with || true (or using || { echo "::error::..."; exit 1; }) keeps the diagnostic useful:

♻️ Suggested guard

-          PYPROJECT_VERSION=$(grep '^version = ' pyproject.toml | sed 's/version = "\(.*\)"/\1/')
-          INIT_VERSION=$(grep '^__version__ = ' squawk_alembic/__init__.py | sed 's/__version__ = "\(.*\)"/\1/')
+          PYPROJECT_VERSION=$(grep '^version = ' pyproject.toml | sed 's/version = "\(.*\)"/\1/' || true)
+          INIT_VERSION=$(grep '^__version__ = ' squawk_alembic/__init__.py | sed 's/__version__ = "\(.*\)"/\1/' || true)

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In @.github/workflows/ci.yml around lines 37 - 38, The two command substitutions
that set PYPROJECT_VERSION and INIT_VERSION can fail if grep finds no match,
causing the step to abort; modify the assignments for PYPROJECT_VERSION and
INIT_VERSION so the grep pipelines are guarded (e.g., append "|| true" to the
substitutions) and then explicitly check if the resulting variables are empty—if
empty, emit a clear GitHub Actions error (echo "::error::...") and exit 1;
update the code around the PYPROJECT_VERSION and INIT_VERSION assignments to
perform the guarded capture followed by the explicit error handling.

Configuration used: Organization UI

Review profile: CHILL

Plan: Lite

tests/test_main.py (1)

221-294: Good coverage of the three diff-branch scenarios.

The three new tests cover the key paths:

• Skip when file exists on branch (1 call)
• Lint when file is new (3 calls)
• No diff-branch flag means no git call (2 calls)

Call-count assertions and command-name checks provide reasonable confidence in the dispatch logic.

One minor observation: there's no test for when --diff-branch references a non-existent branch (e.g., --diff-branch nonexistent). In that case git cat-file -e returns non-zero, so the file would be linted — which is correct fail-open behavior. A test documenting this would be a nice addition but isn't critical.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@tests/test_main.py` around lines 221 - 294, Add a test that covers the case
where --diff-branch names a non-existent branch: create a new test (e.g.,
test_diff_branch_nonexistent_branch_lints_file) mirroring
test_diff_branch_lints_new_file but pass "--diff-branch", "nonexistent" in
patched sys.argv and use patch("subprocess.run",
side_effect=fake_subprocess(git_exists_on_branch=False)) as mock_run; assert
main() == 0 and that mock_run.call_count == 3 (git cat-file + alembic + squawk)
and optionally assert the first subprocess call was "git" to document the
expected dispatch behavior.

Configuration used: Organization UI

Review profile: CHILL

Plan: Lite

squawk_alembic/hook.py (1)

133-160: Optional: guard git subprocess calls against FileNotFoundError.

Both validate_branch and file_exists_on_branch call git without catching FileNotFoundError. In the pre-commit context, git is always present, so the practical risk is negligible. Still, an unhandled exception here would produce an ugly traceback rather than the clean error messages used elsewhere in the file.

♻️ Suggested guard (consistent with the existing alembic/squawk pattern)

 def validate_branch(branch):
     """Validate that a branch name is safe and exists in git."""
     if not _BRANCH_RE.match(branch):
         print(
             f"squawk-alembic: invalid branch name: {branch!r}",
             file=sys.stderr,
         )
         return False
-    result = subprocess.run(
-        ["git", "rev-parse", "--verify", branch],
-        capture_output=True,
-    )
+    try:
+        result = subprocess.run(
+            ["git", "rev-parse", "--verify", branch],
+            capture_output=True,
+        )
+    except FileNotFoundError:
+        print("squawk-alembic: git not found", file=sys.stderr)
+        return False
     if result.returncode != 0:

 def file_exists_on_branch(filepath, branch):
     """Check if a file exists on the given git branch."""
-    result = subprocess.run(
-        ["git", "cat-file", "-e", f"{branch}:{filepath}"],
-        capture_output=True,
-    )
-    return result.returncode == 0
+    try:
+        result = subprocess.run(
+            ["git", "cat-file", "-e", f"{branch}:{filepath}"],
+            capture_output=True,
+        )
+        return result.returncode == 0
+    except FileNotFoundError:
+        return False

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@squawk_alembic/hook.py` around lines 133 - 160, Wrap the subprocess.run calls
in validate_branch and file_exists_on_branch with a try/except that catches
FileNotFoundError; on FileNotFoundError print a concise squawk-alembic error to
stderr (consistent with existing messages) and return False so the functions
fail gracefully instead of raising a traceback. Ensure you modify the
validate_branch function around the git rev-parse call and file_exists_on_branch
around the git cat-file call, preserving existing return semantics and using the
same stderr printing style.

Configuration used: Organization UI

Review profile: CHILL

Plan: Lite

Configuration used: Organization UI

Review profile: CHILL

Plan: Lite

squawk_alembic/hook.py (1)

135-169: LGTM — validate_branch and file_exists_on_branch handle missing git properly.

Both functions catch FileNotFoundError for the git binary. The control flow in main ensures validate_branch runs first (returning 1 on failure), so file_exists_on_branch's FileNotFoundError → False fallback is purely defensive and won't silently suppress lint.

🤖 Prompt for AI Agents

Verify each finding against the current code and only fix it if needed.

In `@squawk_alembic/hook.py` around lines 135 - 169, No change required: both
validate_branch and file_exists_on_branch correctly handle a missing git binary
by catching FileNotFoundError; keep the existing try/except in validate_branch
and file_exists_on_branch as-is to ensure validate_branch still runs first and
returns 1 on failure while file_exists_on_branch remains defensive and returns
False when git is unavailable.

Configuration used: Organization UI

Review profile: CHILL

Plan: Lite